so php just admitted to doing the funniest thing https://mastodon.social/@ne_/117518126502340764
0 Boosts
0 Likes
Discussion
so php just admitted to doing the funniest thing https://mastodon.social/@ne_/117518126502340764
I don’t intend to call out anyone on here with this, but it’s important to reflect:
- I was told that both the slop PHP patch and the slop kernel patchset were high quality code with very few telltale signs of slop
- both of them had a bunch of telltale signs of slop (and again I’m really not trying to call anyone out for this, please consider this a postmortem)
- both were rushed through with very little to no understanding of the problem they were solving
- both were highly publicized but solved little to nothing: the linux patchset was flawed and decreased performance outside of microbenchmarks, and the php patch fixed an issue that was hard-to-impossible to exploit in practice with a gigantic number of slop-looking changes when another fix (abort on OOM now and gradually patch exploitable cases) was available, but nobody considered it because nobody considered anything
just some things to consider going forward. you absolutely don’t gotta hand it to any of these people.