Post by @algernon@come-from.mad-scientist.club

@algernon@come-from.mad-scientist.club 4 hr. ago

0 Boosts

0 Likes

@algernon@come-from.mad-scientist.club 4 hr. ago

thread 'main' (1561830) panicked at .../roto-0.13.0/src/typechecker/scope.rs:259:30:
called `Option::unwrap()` on a `None` value
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Oof. I've seen this before when I was trying to match on an Option as if it was a Result, but this time I'm matching a Result with Ok and Err arms.

mouse-shaped corner case magnet

@algernon@come-from.mad-scientist.club 4 hr. ago

fn bleah() {
let matcher = matchers.Patterns.new(["GPTBot", "AnnoyingScraper"]);
match matcher {
Ok(v) => {},
_ => {}
}
}

This works. But if the Ok arm is Ok(v) => v, it panics. Lets see if I can repro it with a smaller case.

mouse-shaped corner case magnet

@algernon@come-from.mad-scientist.club 4 hr. ago

mouse-shaped corner case magnet

@algernon@come-from.mad-scientist.club 4 hr. ago

thread 'main' (1573206) panicked at iocaine-powder/src/sex_dungeon/means_of_production/voyeurs.rs:46:103:
called `Result::unwrap()` on an `Err` value: × Error constructing pattern matcher: blah
╰─▶ boo

Not the nicest way to fail, but the best I can do right now.

Later on, there will be an (optional) fn validate_configuration() -> Result<(), Report> function on the Roto side, where I can use normal new, and feed any errors into the final Report. And that will be able to provide a nicer error, and will be called during iocaine's init.

~18 more replies

mouse-shaped corner case magnet

@algernon@come-from.mad-scientist.club 4 hr. ago

const KNOWN_ROBOTS: matchers.Patterns =
matchers.Patterns.unsafe_new(
["GPTBot", "AnnoyingScraper"],
Report.new("failed to construct KNOWN_BOTS")
);

Not so bad.

mouse-shaped corner case magnet

@algernon@come-from.mad-scientist.club 4 hr. ago

mouse-shaped corner case magnet

@algernon@come-from.mad-scientist.club 4 hr. ago

Huh.

const KNOWN_ROBOTS: matchers.Patterns = get_known_robots();

fn get_known_robots() -> matchers.Patterns {
let robots = matchers.Patterns.new(["GPTBot", "AnnoyingScraper"]);
match robots {
Ok(val) => val,
Err(_) => matchers.Patterns.unsafe_new([], Report.new("Failed to construct empty KNOWN_ROBOTS")),
}
}

This works. Which means I can do the thing I wanna do, but I still need that unsafe_new(). Or, I need a .default(), which constructs a matcher that never matches, and I can do error handling entirely on the Roto side.

I think I like that better.

mouse-shaped corner case magnet

@algernon@come-from.mad-scientist.club 3 hr. ago

thread 'main' (1589097) panicked at iocaine-powder/src/sex_dungeon/means_of_production/voyeurs/regexes.rs:35:26:
failed to construct default matchers.Regex: Syntax(
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
regex parse error:
^(?!x)x
^^^
error: look-around, including look-ahead and look-behind, is not supported
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
)

YAY!

Not friendly yet, but at least it tells the error.

mouse-shaped corner case magnet

@algernon@come-from.mad-scientist.club 3 hr. ago

Next: IP prefix matcher. There, I'm thinking about changing the API a little.

In iocaine 3, you constructed a matcher by doing Matcher.from_ip_prefixes(StringList.new().push("127.0.0.1/32")). You gave it a string list, and it made a matcher. Simple.

In iocaine 4, I can do this:

let matcher = matchers.IPPrefix.new([
[127.0.0.1 / 32, "localhost"]
]);

matcher.matches(127.0.0.1 / 32) // returns bool
matcher.longest_match(127.0.0.1 / 32) // returns Some("localhost")

The goal here is to be able to use the longest match's data part for logging, or... whatever else. Come to think of it...

match matcher.longest_match(127.0.0.1 / 32) {
Some(data) => { ... }
None => {},
}

That could also work, and then we only perform the lookup once. The downside is that if I'm only interested if it matches, I still have to unwrap it... so I guess the .matches() variant is still useful.

mouse-shaped corner case magnet

@algernon@come-from.mad-scientist.club 2 hr. ago

mouse-shaped corner case magnet

@algernon@come-from.mad-scientist.club 2 hr. ago

test test_ipprefix {
let matcher = matchers.IpPrefixes.new([127.0.0.1 / 32]);
if !matcher.matches(127.0.0.1 / 32) { reject }
if matcher.matches(10.0.0.1 / 24) { reject }

let prefix = match "127.0.0.1/32".to_prefix() {
Ok(v) => v,
Err(_) => { reject },
};
if !matcher.matches(prefix) { reject }

accept
}

This passes just fine, yay!